Add double quotes

Signed-off-by: Mustafa Abdelrahman <[email protected]>
zalando · Aug 8, 2023 · 5b5cf9c · 5b5cf9c
1 parent 919cf5f
commit 5b5cf9c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/cmd/webhook/admission/admission_test.go b/cmd/webhook/admission/admission_test.go
@@ -168,22 +168,22 @@ func TestIngressAdmitter(t *testing.T) {
 		{
 			name:      "invalid eskip filters",
 			inputFile: "invalid-filters.json",
-			message:   "Ingress validation failed: parsing zalando.org/skipper-filter annotation failed: parse failed after token this, last route id: , position 9: syntax error",
+			message:   `Ingress validation failed: parsing \"zalando.org/skipper-filter\" annotation failed: parse failed after token this, last route id: , position 9: syntax error`,
 		},
 		{
 			name:      "invalid eskip predicates",
 			inputFile: "invalid-predicates.json",
-			message:   "Ingress validation failed: parsing zalando.org/skipper-predicate annotation failed: parse failed after token ), last route id: , position 15: syntax error",
+			message:   `Ingress validation failed: parsing \"zalando.org/skipper-predicate\" annotation failed: parse failed after token ), last route id: , position 15: syntax error`,
 		},
 		{
 			name:      "invalid eskip routes",
 			inputFile: "invalid-routes.json",
-			message:   "Ingress validation failed: parsing zalando.org/skipper-routes annotation failed: invalid predicate count arg",
+			message:   `Ingress validation failed: parsing \"zalando.org/skipper-routes\" annotation failed: invalid predicate count arg`,
 		},
 		{
 			name:      "invalid eskip filters and predicates",
 			inputFile: "invalid-filters-and-predicates.json",
-			message:   "Ingress validation failed: parsing zalando.org/skipper-filter annotation failed: parse failed after token this, last route id: , position 9: syntax error\\nparsing zalando.org/skipper-predicate annotation failed: parse failed after token ), last route id: , position 15: syntax error",
+			message:   `Ingress validation failed: parsing \"zalando.org/skipper-filter\" annotation failed: parse failed after token this, last route id: , position 9: syntax error\nparsing \"zalando.org/skipper-predicate\" annotation failed: parse failed after token ), last route id: , position 15: syntax error`,
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {

diff --git a/dataclients/kubernetes/definitions/ingressvalidator.go b/dataclients/kubernetes/definitions/ingressvalidator.go
@@ -47,7 +47,7 @@ func (IngressV1Validator) validateFilterAnnotation(annotations map[string]string
 	if filters, ok := annotations[skipperfilterAnnotationKey]; ok {
 		_, err := eskip.ParseFilters(filters)
 		if err != nil {
-			err = fmt.Errorf("parsing %s annotation failed: %w", skipperfilterAnnotationKey, err)
+			err = fmt.Errorf("parsing \"%s\" annotation failed: %w", skipperfilterAnnotationKey, err)
 		}
 		return err
 	}
@@ -58,7 +58,7 @@ func (IngressV1Validator) validatePredicateAnnotation(annotations map[string]str
 	if predicates, ok := annotations[skipperpredicateAnnotationKey]; ok {
 		_, err := eskip.ParsePredicates(predicates)
 		if err != nil {
-			err = fmt.Errorf("parsing %s annotation failed: %w", skipperpredicateAnnotationKey, err)
+			err = fmt.Errorf("parsing \"%s\" annotation failed: %w", skipperpredicateAnnotationKey, err)
 		}
 		return err
 	}
@@ -69,7 +69,7 @@ func (IngressV1Validator) validateRoutesAnnotation(annotations map[string]string
 	if routes, ok := annotations[skipperRoutesAnnotationKey]; ok {
 		_, err := eskip.Parse(routes)
 		if err != nil {
-			err = fmt.Errorf("parsing %s annotation failed: %w", skipperRoutesAnnotationKey, err)
+			err = fmt.Errorf("parsing \"%s\" annotation failed: %w", skipperRoutesAnnotationKey, err)
 		}
 		return err
 	}