fix: 2852 unspecified addresses should fail

Signed-off-by: Sandor Szücs <[email protected]>
zalando · Jan 14, 2024 · 4d01eeb · 4d01eeb
1 parent 14cec82
commit 4d01eeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/net/net.go b/net/net.go
@@ -144,6 +144,8 @@ func ParseIPCIDRs(cidrs []string) (*netipx.IPSet, error) {
 
 		} else if addr, err := netip.ParseAddr(w); err != nil {
 			return nil, err
+		} else if addr.IsUnspecified() {
+			return nil, fmt.Errorf("failed to parse cidr: addr is unspcified: %s", w)
 		} else {
 			b.Add(addr)
 		}

diff --git a/net/net_test.go b/net/net_test.go
@@ -179,6 +179,10 @@ func TestParseIPCIDRs(t *testing.T) {
 		input   []string
 		wantErr bool
 	}{
+		{[]string{"::"}, true},
+		{[]string{"f::"}, false},
+		{[]string{"::1"}, false},
+		{[]string{"::1/8"}, false},
 		{[]string{"1.2.3.4.5"}, true},
 		{[]string{"1.2.3.4/"}, true},
 		{[]string{"1.2.3.4/245"}, true},