review comments

Signed-off-by: Janardhan Sharma <[email protected]>
zalando · May 10, 2024 · 3307de3 · 3307de3
1 parent aef72d0
commit 3307de3
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/filters/openpolicyagent/evaluation.go b/filters/openpolicyagent/evaluation.go
@@ -78,22 +78,21 @@ func setDecisionIdInRequest(req *ext_authz_v3.CheckRequest, decisionId string) e
 			FilterMetadata: map[string]*pbstruct.Struct{},
 		}
 	}
-	filterMeta, err := formOpenPolicyAgentMetaDataObject(decisionId)
 
-	if err == nil {
-		req.Attributes.MetadataContext.FilterMetadata["open_policy_agent"] = filterMeta
+	filterMeta, err := formOpenPolicyAgentMetaDataObject(decisionId)
+	if err != nil {
+		return err
 	}
-	return err
+	req.Attributes.MetadataContext.FilterMetadata["open_policy_agent"] = filterMeta
+	return nil
 }
 
 func formOpenPolicyAgentMetaDataObject(decisionId string) (*pbstruct.Struct, error) {
 
 	innerFields := make(map[string]interface{})
 	innerFields["decision_id"] = decisionId
 
-	openPolicyAgentMetaDataObject, err := pbstruct.NewStruct(innerFields)
-
-	return openPolicyAgentMetaDataObject, err
+	return pbstruct.NewStruct(innerFields)
 }
 
 func (opa *OpenPolicyAgentInstance) logDecision(ctx context.Context, input interface{}, result *envoyauth.EvalResult, err error) error {