Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use spring-boots ssl-bundle support #1673

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jbellmann
Copy link
Contributor

This PR makes it possible to use spring-boots mechanism configuring SSL certificates/truststore/keystore with Riptide.

Description

In Spring-Boot 3.1 a new feature was introduced to secure applications with SSL.
That was further enhanced in Spring-Boot 3.2.

Motivation and Context

With a defined Spring-Boot way for configuring certificates/keystores/truststores it would make sense to support an option to use that well-documented feature together with Riptide.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jbellmann
Copy link
Contributor Author

@fatroom Hi Roman, I guess this PR needs a specific label to be set by the maintainers to start the build, right? I'm currently not able to set any.
Maybe you could have a look into it and set the required label to start the build step or request some changes to the PR?
Thank you.

@fatroom fatroom added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Dec 15, 2024
@fatroom
Copy link
Member

fatroom commented Dec 16, 2024

👍

1 similar comment
@yuppie-flu
Copy link
Member

👍

@fatroom fatroom merged commit b3d0a72 into zalando:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants