Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrently fetch metrics #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Concurrently fetch metrics #12

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3b244c
fix: concurrently fetch metrics
AnshulMalik Apr 7, 2024
4bb8c8e
chore: review comments
AnshulMalik Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions internal/insight/insight.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ package insight

import (
"context"
"sync"
"time"

"github.com/aws/aws-sdk-go-v2/aws"
Expand Down Expand Up @@ -65,17 +66,37 @@ func (in *Insight) Fetch(ctx context.Context, dbiResourceId string, dur time.Dur
chunks = append(chunks, metrics[i:end])
}

// TODO: concurrent
childContext, cancel := context.WithCancel(ctx)
defer cancel()

samples := map[string]Samples{}
for _, chunk := range chunks {
set, err := in.fetch(ctx, dbiResourceId, dur, chunk...)
if err != nil {
return nil, err
}
var wg sync.WaitGroup
var err error

for k, v := range set {
samples[k] = v
}
for _, chunk := range chunks {
chunk := chunk
wg.Add(1)

go func() {
defer wg.Done()

set, e := in.fetch(childContext, dbiResourceId, dur, chunk...)
if e != nil {
if e != context.Canceled {
cancel()
err = e
}
return
}

for k, v := range set {
samples[k] = v
fogfish marked this conversation as resolved.
Show resolved Hide resolved
}
}()
}
wg.Wait()
if err != nil {
return nil, err
}

return samples, nil
Expand Down