Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow hyphens in database name #2815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow hyphens in database name #2815

wants to merge 1 commit into from

Conversation

JeffResc
Copy link

Allow for hyphens in the database name, they are currently supported by Postgres, but not this operator

Current behavior:

time="2024-12-10T22:58:31Z" level=info msg="database \"my-database\" has invalid name" cluster-name=postgres/pg-cluster pkg=cluster

@FxKu
Copy link
Member

FxKu commented Dec 18, 2024

@JeffResc thanks for your PR. I would prefer to make the database regex configurable like it was attempted in #2139. Maybe you can pick up the work done there?

@FxKu FxKu added the minor label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@FxKu FxKu Awaiting requested review from FxKu FxKu is a code owner

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

@macedigital macedigital Awaiting requested review from macedigital macedigital is a code owner

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffResc @FxKu