improve additional teams lookup #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda and
hughcapet
as code owners
Jan-M
reviewed
Oct 13, 2023
Jan-M
reviewed
Oct 13, 2023
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across a team mapping resource where 11 teams where cross referencing one another. Although the lookup of additional teams is already and exclusion filter it seemed that there were still to many lookups performed bringing the operator to a halt.
The PR changes how
fetchAdditionalTeamsmust be called. The team for which the lookup is done must already be added to theexcludefilter so that additional teams will be added to the filter as well before doing a recursive call. Transitive teams will be added to the exclude filter, too, to avoid unnecessary look ups in case they are also an additional team to the original team.I counted the lookups for one of the unit tests and the number of loops was reduced from 11 to 5 with only little cross-referecing.