Merge pull request #1072 from zalando/ARUHA-2359

close zk session after unregistering session
zalando · Jun 21, 2019 · e55cde3 · e55cde3
2 parents e2d7e2b + cda8d12
commit e55cde3
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/org/zalando/nakadi/service/subscription/state/CleanupState.java b/src/main/java/org/zalando/nakadi/service/subscription/state/CleanupState.java
@@ -20,11 +20,8 @@ public CleanupState(@Nullable final Exception e) {
     public void onEnter() {
         try {
             getContext().unregisterAuthorizationUpdates();
-            getContext().getZkClient().close();
         } catch (final RuntimeException ex) {
             getLog().error("Unexpected fail during removing callback for registration updates", ex);
-        } catch (IOException e) {
-            getLog().error("Unexpected fail to release zk connection", e);
         }
         try {
             if (null != exception) {
@@ -36,6 +33,12 @@ public void onEnter() {
             } finally {
                 switchState(StreamingContext.DEAD_STATE);
             }
+
+            try {
+                getContext().getZkClient().close();
+            } catch (final IOException e) {
+                getLog().error("Unexpected fail to release zk connection", e);
+            }
         }
     }
 }