-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose all HAR "entry" fields #48
Conversation
Signed-off-by: Oliwia Zaremba <[email protected]>
Signed-off-by: Oliwia Zaremba <[email protected]>
Signed-off-by: Oliwia Zaremba <[email protected]>
🤖 zincr found 0 problems , 0 warnings
|
196927b
to
c111e21
Compare
This is WIP until the issue of failing Travis build is solved... |
47c84a2
to
d1fabc3
Compare
Signed-off-by: Oliwia Zaremba <[email protected]>
d1fabc3
to
828ed8a
Compare
Travis build is now back to normal with a simple workaround of downgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
Expose all HAR "entry" fields.
Closes #35
Description
Added a new property in the
Request
class to expose all the information about a single entry that was recorded in the HAR file, and that used to be ignored in our intermediate representation.Types of Changes
Review
Reviewers' checklist:
good tests for these flows?
If this PR rather removes flows, are the obsolete tests removed as well?
technical (in source files) and functional (under
docs/
) documentation.In doubt, refer to https://semver.org.