skipper-ingress: disable automated healthcheck routes #9241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponimas
added
the
major
ponimas
force-pushed
the
skipper/inline-kube-health-2
branch
from
c736504 to
d6efa24
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
5e38359 to
758162c
Compare
ponimas
changed the title
ponimas
force-pushed
the
skipper/inline-kube-health-2
branch
from
d6efa24 to
2c8324b
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
758162c to
97ab99a
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-2
branch
from
2c8324b to
362d805
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
97ab99a to
d7df0bb
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-2
branch
3 times, most recently
from
1484a5e to
be20c54
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
d7df0bb to
1f2aad7
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
1f2aad7 to
84f7a84
Compare
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
2 times, most recently
from
2f2fd1d to
89d9fa9
Compare
With routesrv disabled Skipper will add default filters to healthcheck routes. |
Skipper provides two flags to control kubernetes healthcheck routes: `-kubernetes-healthcheck` (true by default) that enables automatic healthcheck routes and `-reverse-source-predicate` to select source predicate type. Currently when routesrv is enabled (default state) it adds automatic healthcheck routes and appends default filters to all routes including healthcheck routes. We want to avoid adding default filters to healthcheck routes. The explicit inlined checks were created in #9206 This change disables automatic healthcheck routes provided by routesrv. This reverts commit d6efa24. Signed-off-by: Aleksandr Ponimaskin <[email protected]>
Remove the conditional configuration for IPv6 healthcheck CIDR whitelisting for routeserv in the skipper deployment manifest. This option is no longer necessary as the healthchecks are moved to the skipper-ingress level. Signed-off-by: Aleksandr Ponimaskin <[email protected]>
We need to exclude healthcheck routes from the authentication even cases when the routeserv is disabled to keep the backwards compartibility.
ponimas
force-pushed
the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
from
89d9fa9 to
f2e588c
Compare
Signed-off-by: Aleksandr Ponimaskin <[email protected]>
|
👍 |
1 similar comment
|
👍 |
AlexanderYastrebov
deleted the
skipper/inline-kube-health-disable-checks-at-routeserv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipper provides two flags to control kubernetes healthcheck routes:
-kubernetes-healthcheck(true by default) that enables automatic healthcheck routesand
-reverse-source-predicateto select source predicate type.Currently when routesrv is enabled (default state) it adds
automatic healthcheck routes and appends default filters to
all routes including healthcheck routes.
We want to avoid adding default filters to healthcheck routes. The explicit inlined checks were created in this PR.
This change disables automatic healthcheck routes provided by routesrv.
Additionally this PR add an iam anotation to these healhcheck routes to opt-out them from the authentication.
This PR should be merged only after this one is deployed.