Validation webhook for ingress #6341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluster/manifests/01-admission-control/routegroups-webhook.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
add initial deletion remove condition for webhook to work always with ingress at least Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
force-pushed
the
validation-webhook-for-ingress
branch
from
3f6e929
to
ac7b3a8
Compare
MustafaSaber
commented
Aug 16, 2023
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
|
👍 |
1 similar comment
|
👍 |
This was referenced Aug 23, 2023
Merged
Merged
Merged
Merged
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 24, 2023
Followup on #6341 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 24, 2023
Followup on #6341 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 24, 2023
Similar to existing routegroups_validation. Tested that it works also when both are disabled: ``` ~$ kubectl get ValidatingWebhookConfiguration skipper-admitter.teapot.zalan.do NAME WEBHOOKS AGE skipper-admitter.teapot.zalan.do 0 27h ``` Followup on #6341 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 24, 2023
Use version before #6341. PR #6384 introduces config item for ingress validation. Signed-off-by: Alexander Yastrebov <[email protected]>
mikkeloscar
pushed a commit
that referenced
this pull request
Aug 25, 2023
Use version before #6341. PR #6384 introduces config item for ingress validation. Signed-off-by: Alexander Yastrebov <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing validation for skipper
IngressannotationsRelated zalando/skipper#2493 & zalando/skipper#1618