Skip to content

Commit

Permalink
Fix trigger_comment newline
Browse files Browse the repository at this point in the history
Fix yaml in prow.yaml PR or it would cause issues to the controller not
being able to parse it.

The pac controller would get:

🚨 11:31:31 pac-controller prun:  tekton validation error: yaml: line
16: could not find expected ':'

it's all deep down inside the decoder method:

decoder := k8scheme.Codecs.UniversalDeserializer()

so nothing we can really do on our side, and we have to tell our users
to have to use the |- thing instead.

Signed-off-by: Chmouel Boudjnah <[email protected]>
  • Loading branch information
chmouel authored and pipelines-as-code[bot] committed Feb 7, 2025
1 parent dcae131 commit 799386b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .tekton/prow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
spec:
params:
- name: trigger_comment
value: |
value: |-
{{ trigger_comment }}
- name: repo_owner
value: "{{ repo_owner }}"
Expand Down
2 changes: 1 addition & 1 deletion docs/content/docs/guide/authoringprs.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ You will encounter a YAML validation error because objects or multiline strings
spec:
params:
- name: body
value: |
value: |-
{{ body }}
# Alternatively, use '>' to specify that the value will be in block format
- name: pull_request
Expand Down

0 comments on commit 799386b

Please sign in to comment.