Fixed example 3.5 in README + Added example 4.1 with test #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the
build_SB_example35()
function in the README was incomplete since it did not assign -1 reward to actions which took the agent off-grid. The version inside examples/simple.py had the complete reward matrix and I simply copied few lines in the README to avoid any newcomer's confusion.Also it took me a while to understand the MDP dynamics in presence of terminal states since an extra absorbing state is added in this framework. Thought it will be good to have Example 4.1 from the book completed inside the same simple examples file. Also added a test to verify the analytic solution of
V_pi
for that example.The test also highlights the fact that we need to remove the elements corresponding to the added absorbing state to solve for
V_pi
correctly i.e., without making the matrixI - gamma * P_pi
singular.