-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6: Improves grammar #7
Conversation
… options in the grammar
…ts in the grammar
@@ -0,0 +1 @@ | |||
DJANGO_PATH = 'ENV/lib/python3.4/site-packages/django/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rusty on how Atom plugins are written, but is it not a concern being hardcoded to a certain Python version here?
Hey @zacharytamas These scripts will never be executed or used by atom. The idea is to use them to update Django settings and shortcuts functions in the grammar when a new version comes out. They may not even be effective actually but I included them since I wrote it anyway to extract that from the source code. Basically you would run the script, and it would generate something like this:
Then you copy it into the grammar file. |
Ah okay. I thought maybe you were training Atom to introspect |
Hey @benjohnson @jpells @zacharytamas here is the first pull request for #6
It greatly improves the grammar:
I also added keywords to the package.json file to improve package discovery (http://blog.atom.io/2015/03/30/keywords-on-atom-io.html)
Let me know if you guys have any suggestions to further improve this =D