Fix rule violations #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update context from 0052 to 0056
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: William Jamieson <[email protected]>
Patch pyproject
github-actions
bot
added
documentation
WilliamJamieson
commented
Feb 21, 2024
| @@ -150,6 +150,6 @@ def get_exposure_type(self, item, default="science"): | |||
| exp_type = item["exp_type"] | |||
|
|
|||
| if exp_type == "wfi_image": | |||
| exp_type == "science" | |||
| exp_type = "science" | |||
There was a problem hiding this comment.
This creates a test failure, but it is clearly a bug.
zacharyburnett
pushed a commit
that referenced
this pull request
Aug 12, 2024
Propagate more DQ flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performed a rebase and then fixed all the rule violations. You have the ability for maintainers to push changes to your branch turned off so I could not push these to this branch. So feel free to just examine this branch and cherry pick the commits off of it or reset your branch to these changes.
Checklist
CHANGES.rstunder the corresponding subsectionupdate context from 0052 to 0056