Skip to content

Commit

Permalink
add review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
zacharyburnett committed Aug 12, 2024
1 parent 7b69c92 commit 0f0616b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 6 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/roman_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,15 @@ on:
workflow_dispatch:
inputs:
crds_context:
description: CRDS context
description: CRDS context (leave blank for latest)
type: string
required: false
default: ''
crds_server:
description: CRDS server
type: string
required: false
default: https://roman-crds.stsci.edu

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }}
Expand Down Expand Up @@ -54,7 +59,7 @@ jobs:
setenv: |
WEBBPSF_PATH: /tmp/data/webbpsf-data/
CRDS_PATH: /tmp/data/crds_cache/
CRDS_SERVER_URL: https://roman-crds.stsci.edu
CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }}
CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }}
CRDS_CLIENT_RETRY_COUNT: 3
CRDS_CLIENT_RETRY_DELAY_SECONDS: 20
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/roman_ci_cron.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,15 @@ on:
workflow_dispatch:
inputs:
crds_context:
description: CRDS context
description: CRDS context (leave blank for latest)
type: string
required: false
default: ''
crds_server:
description: CRDS server
type: string
required: false
default: https://roman-crds.stsci.edu

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }}
Expand Down Expand Up @@ -54,7 +59,7 @@ jobs:
setenv: |
WEBBPSF_PATH: /tmp/data/webbpsf-data/
CRDS_PATH: /tmp/data/crds_cache/
CRDS_SERVER_URL: https://roman-crds.stsci.edu
CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }}
CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }}
CRDS_CLIENT_RETRY_COUNT: 3
CRDS_CLIENT_RETRY_DELAY_SECONDS: 20
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/tests_devdeps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,15 @@ on:
workflow_dispatch:
inputs:
crds_context:
description: CRDS context
description: CRDS context (leave blank for latest)
type: string
required: false
default: ''
crds_server:
description: CRDS server
type: string
required: false
default: https://roman-crds.stsci.edu

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ inputs.crds_context }}
Expand Down Expand Up @@ -53,7 +58,7 @@ jobs:
setenv: |
WEBBPSF_PATH: /tmp/data/webbpsf-data/
CRDS_PATH: /tmp/data/crds_cache/
CRDS_SERVER_URL: https://roman-crds.stsci.edu
CRDS_SERVER_URL: ${{ github.event_name == 'workflow_dispatch' && inputs.crds_server || 'https://jwst-crds.stsci.edu' }}
CRDS_CONTEXT: ${{ needs.crds_context.outputs.context }}
CRDS_CLIENT_RETRY_COUNT: 3
CRDS_CLIENT_RETRY_DELAY_SECONDS: 20
Expand Down

0 comments on commit 0f0616b

Please sign in to comment.