Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jsonlint.parse / parser binding #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charleswisniewski
Copy link

@josdejong Can you please better explain the change here?

I would love to get this change into the canonical version of jsonlint so that npm is updated with this change so we do not have to do an installation from github @honzajavorek fyi -this corresponds to a change here:

@josdejong
Copy link

I don't remember exactly, but I've removed all stuff related to running jsonlint as a command line application. That code was giving issues when trying to run it as a library.

charleswisniewski pushed a commit to charleswisniewski/gavel.js that referenced this pull request Jun 1, 2017
@honzajavorek
Copy link

@charleswisniewski Thanks for the PR, but

  1. If @josdejong removed some parts to resolve certain issues, that can be good enough for the fork, but the upstream solution should probably be to fix the parts instead of removing them.
  2. Do not have very high hopes in this PR being reviewed or even merged. The package is currently unmaintained. That's why all sorts of forks exist in the first place. I made some efforts to help with the issue, but with no response so far. See Accept pull requests? #56 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants