Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
balance sanitization
Observations
1. Cannot convert negative number into BigUint: test_negative_big_uint_conversion
to_biguint
returnsNone
. Sounwrap()
panicsmerkle_sum_tree::utils::big_uint_to_fp
2. Field elements are non-negative values. So it doesn't seem possible to get a negative value into mst or range_check: test
halo2_proofs::halo2curves::bn256::Fr
does not implementFrom
trait for any signed integer typeshalo2curves
is at v0.6.13.
csv_parser
andmerkle_sum_tree
errors when using negative values: test_parse_csv_to_entries, test_mst_negative_value_in_csv