Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix for transform_column_name and changed code to pass test #98

Conversation

loveeklund-osttra
Copy link
Contributor

transform_column_name gets called with unpacked arguments. This means that you can get errors like this
TypeError: transform_column_name() got an unexpected keyword argument 'replace_period_with_underscore'
if you run a version of the target that doesn't have that column_name_transforms.

I assume the reason is that meltano does some weird logic where it pulls the config options from the latest version of the target but allows for previous version of the code.

This PR should fix it and also solve the problems with the tests that fails ( It worked when I ran the tests locally)

@z3z1ma z3z1ma merged commit 9d1d0b0 into z3z1ma:main Sep 30, 2024
0 of 3 checks passed
@arozamena
Copy link

Hi im new here im getting with the plugin the error , I was trying with pip_url: z3-target-bigquery==0.7.2 and olders and with meltano pip install meltano==3.5.0

code=1 message=TypeError: transform_column_name() got an unexpected keyword argument 'replace_period_with_underscore' name=meltano run_id=32d=2024-10-15T171557--tap-csv--target-bigquery

Any idea how resolved ?

@loveeklund-osttra
Copy link
Contributor Author

@arozamena Try running it with a fixed hash ( this one should work 9d1d0b0) in the meltano.yaml file and make sure you reinstall the package after updating the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants