added fix for transform_column_name and changed code to pass test #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform_column_name gets called with unpacked arguments. This means that you can get errors like this
TypeError: transform_column_name() got an unexpected keyword argument 'replace_period_with_underscore'
if you run a version of the target that doesn't have that
column_name_transforms
.I assume the reason is that meltano does some weird logic where it pulls the config options from the latest version of the target but allows for previous version of the code.
This PR should fix it and also solve the problems with the tests that fails ( It worked when I ran the tests locally)