Add test for update_undocumented_columns_with_prior_knowledge function #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syou6162
commented
Sep 21, 2023
syou6162
force-pushed
the
add_test_update_undocumented_columns_with_prior_knowledge
branch
from
66af788
to
dbe9c24
Compare
syou6162
commented
Sep 21, 2023
syou6162
commented
Sep 21, 2023
syou6162
commented
Sep 21, 2023
syou6162
changed the title
update_undocumented_columns_with_prior_knowledge function
syou6162
changed the title
update_undocumented_columns_with_prior_knowledge function
syou6162
commented
Sep 21, 2023
syou6162
force-pushed
the
add_test_update_undocumented_columns_with_prior_knowledge
branch
from
dbe9c24
to
672b8d6
Compare
z3z1ma
approved these changes
Sep 22, 2023
…umented_columns_with_prior_knowledge
|
@z3z1ma Thank you for reviewing & I fixed conflicted codes! Could you merge this pull request? |
syou6162
commented
Sep 22, 2023
|
lgtm |
syou6162
deleted the
add_test_update_undocumented_columns_with_prior_knowledge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #96.
The
update_undocumented_columns_with_prior_knowledgefunction has a lot of flags (skip_add_tags/skip_merge_meta/add_progenitor_to_meta) involved. Therefore, it was not clear how they behave. We have added a test to this function to make it easier to follow the behavior.In adding testing, I also corrected some behavior that differed from the documentation (the documentation says it mutates the NODE, but in fact it does not).