chore: notebook runtime use filesystem handle attached to spec

z3z1ma · Jun 7, 2024 · 11fddfb · 11fddfb
1 parent eb440d9
commit 11fddfb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/cdf/cli.py b/src/cdf/cli.py
@@ -366,13 +366,7 @@ def notebook(
     try:
         return (
             workspace.get_notebook_spec(notebook)
-            .bind(
-                lambda s: execute_notebook_specification(
-                    s,
-                    storage=workspace.project.filesystem.wrapped,
-                    **json.loads(params),
-                )
-            )
+            .bind(lambda s: execute_notebook_specification(s, **json.loads(params)))
             .unwrap()
         )
     finally:

diff --git a/src/cdf/core/runtime/notebook.py b/src/cdf/core/runtime/notebook.py
@@ -11,7 +11,6 @@
 import typing as t
 from datetime import date, datetime
 
-import fsspec
 import papermill
 
 import cdf.core.logger as logger
@@ -24,7 +23,6 @@
 
 def execute_notebook_specification(
     spec: NotebookSpecification,
-    storage: t.Optional[fsspec.AbstractFileSystem] = None,
     **params: t.Any,
 ) -> M.Result["NotebookNode", Exception]:
     """Execute a notebook specification.
@@ -56,6 +54,7 @@ def execute_notebook_specification(
         logger.info(
             f"Successfully ran notebook {spec.path} with params {merged_params} rendered into {output}"
         )
+        storage = spec.workspace.filesystem
         if storage and spec.storage_path:
             storage_path = spec.storage_path.format(
                 name=spec.name,