forked from jupyterhub/repo2docker-action
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docker push has a couple of advantages over --push in repo2docker: - It times out sometimes, causing issues where the image just fails to push after building. docker push doesn't have this issue - see 2i2c-org/utoronto-image#20, where we had to manually run a docker push. - docker push provides more useful output than --push This commit also removes some code duplication - we now build the image regardless, and use the flag just to differentiate pushing. An unused bash function was also deleted.
- Loading branch information
Showing
1 changed file
with
54 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters