Do not use SETLENGTH
#214
Merged
Do not use SETLENGTH
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current status: this implementation is not correct about unprotecting the old one and protecting the new one. |
yutannihilation
changed the title
SETLENGTH with Rf_xlengthgetsSETLENGTH
|
I'm not sure I like this implementation, but let's go ahead and revisit here when it's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #209.
cf. https://fosstodon.org/@shikokuchuo/112325582047868252
But, the implementation is not efficient. Probably manual
Rf_allocVector()+ memcpy should faster. Or, maybe I can justcollect()into aVecfirst?https://github.com/r-devel/r-svn/blob/faa2ca57cc03c26c49a5de39db980268c6c4cc67/src/main/builtin.c#L832C6-L832C17
Anyway, let's think about it later. I'd like to get rid of the CI error for now.