Lab 8_1_UART #192
Draft
Lab 8_1_UART #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| *.sv | |||
There was a problem hiding this comment.
Не понял, зачем игнорировать .sv файлы?
There was a problem hiding this comment.
Я предполагаю такой сценарий работы:
- выполняется скрипт prepare - копируются файлы из каталога support/step1 в текущий каталог
- идёт работа с файлами
Что бы при обновлении через git pull изменённые файлы не мешали обновлению нужен локальный .gitignore с запретом *.sv
| *.sv | ||
| *.svh | ||
| log.txt | ||
| run |
There was a problem hiding this comment.
Директории нужно игнорировать с / в конце
| *.svh | ||
| log.txt | ||
| run | ||
| uart.conf |
There was a problem hiding this comment.
Это нужно встроить в глобальный .gitignore файл, зачем плодить много локальных?
| @@ -6,6 +6,10 @@ script=$(basename "$0") | |||
| source_script=${script/\.bash/.source_bash} | |||
| dir_source_script=../scripts/steps/$source_script | |||
|
|
|||
| echo $script | |||
There was a problem hiding this comment.
Это лишнее. Все redirect скрипты должны быть индентичными
| dir_source_script=$(readlink -f $dir_source_script) | ||
| . "$dir_source_script" & | ||
|
|
||
| if [ "$OSTYPE" = "msys" ] |
| @@ -0,0 +1,218 @@ | |||
| `include "config.svh" | |||
|
|
|||
| //`ifndef SIMULATION | |||
There was a problem hiding this comment.
Если это тут не нужно, его нужно не комментировать, а удалить
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.