Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactore the Load Balancer Controller #108

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Conversation

duanjiong
Copy link
Collaborator

Remove useless controllers , such as zone, node,etc.
The api is introduced to describe the objects in the load balancer, for example eip, lb, listener, backend etc.
Fix some issues, such as #101, #98, #81, #63
Fix incorrect vip display when there are multiple private ip's.

Signed-off-by: Duan Jiong [email protected]

@duanjiong
Copy link
Collaborator Author

/cc @zheng1

@ks-ci-bot ks-ci-bot requested a review from zheng1 August 31, 2020 10:12
@ks-ci-bot ks-ci-bot added dco-signoff: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2020
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: duanjiong
To complete the pull request process, please assign calvinyv
You can assign the PR to them by writing /assign @calvinyv in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@calvinyv
Copy link
Collaborator

calvinyv commented Sep 1, 2020

@duanjiong @zheng1 make sure this change will not break any existing functions, the regression testing should be fully covered the existing functions.

Remove useless controllers , such as zone, node,etc.
The api is introduced to describe the objects in the load balancer, for example eip, lb, listener, backend etc.
Fix some issues, such as yunify#101, yunify#98, yunify#81, yunify#63
Fix incorrect vip display when there are multiple private ip's.

Signed-off-by: Duan Jiong <[email protected]>
@ks-ci-bot
Copy link
Collaborator

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 187e517 Merge branch 'master' into support-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zheng1 zheng1 merged commit 86eaa9a into yunify:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants