Translate getting-started.md to Japanese #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 91.04% 91.04% -0.01%
==========================================
Files 13 13
Lines 1931 1942 +11
Branches 431 437 +6
==========================================
+ Hits 1758 1768 +10
Misses 117 117
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
yukinarit
reviewed
Jun 16, 2024
| * `toml`：[tomli](https://github.com/hukkin/tomli) と [tomli-w](https://github.com/hukkin/tomli-w) をインストール | ||
| * 注記：python 3.11以降は [tomllib](https://docs.python.org/3/library/tomllib.html) を使用 | ||
| * `yaml`：[pyyaml](https://github.com/yaml/pyyaml) をインストール | ||
| * `numpy`：[numpy](https://github.com/numpy/numpy) をインストール |
There was a problem hiding this comment.
orjsonとsqlalchemyが実は漏れていました。ついでに追加してもらえると助かります 🙇
docs/en/getting-started.md
Outdated
| @@ -13,7 +13,7 @@ If you're using poetry, run this command. | |||
| poetry add pyserde | |||
| ``` | |||
|
|
|||
| Additional data formats besides JSON and Pickle need additional dependencies installed. Install `msgpack`, `toml`, or `yaml` extras to work with the appropriate data formats; you can skip formats that you don't plan to use. For example, if you want to use Toml and YAML: | |||
| Additional data formats besides JSON and Pickle need additional dependencies installed. Install `msgpack`, `toml`, `yaml` or `numpy` extras to work with the appropriate data formats; you can skip formats that you don't plan to use. For example, if you want to use Toml and YAML: | |||
There was a problem hiding this comment.
numpyはデータフォーマットじゃないので、ここに無くても良さそうです。numpyextrasについては”利用可能な追加パッケージ”のところで説明されていました
There was a problem hiding this comment.
失礼しました。ご指摘の通りです。en/jaどちらも削除しました🙇
- Remove `numpy` from the list of additional packages needed for data formats. - Add `orjson` and `sqlalchemy` to the list of extras available with the `all` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #545
また、インストール可能な追加パッケージの説明として
numpyが抜けていると思いましたので英語版Docの方にも追加しています。（認識誤りがありましたらご指摘ください）