Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reuse_instances for non dataclass objects #486

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

yukinarit
Copy link
Owner

Closes #483

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.31%. Comparing base (f1c49f2) to head (43dca1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   89.49%   90.31%   +0.81%     
==========================================
  Files          12       12              
  Lines        1933     1931       -2     
  Branches      401      400       -1     
==========================================
+ Hits         1730     1744      +14     
+ Misses        148      132      -16     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yukinarit yukinarit added the bug Bug report or fix label Mar 9, 2024
@yukinarit yukinarit force-pushed the reuse-instances branch 2 times, most recently from 32edb36 to d1b2b9e Compare March 9, 2024 13:18
@yukinarit yukinarit marked this pull request as ready for review March 9, 2024 14:16
@yukinarit yukinarit merged commit f4ab380 into main Mar 9, 2024
9 checks passed
@yukinarit yukinarit deleted the reuse-instances branch March 9, 2024 14:25
github-actions bot pushed a commit that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report or fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to disable datetime being converted to str
1 participant