Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue with parametrized generics not being supported by
isinstance
. Since you're already relying on beartype, I've found it much easier to strictly rely onis_bearable
to do dispatch, rather thanisinstance
. Stuff just behaves like I expect it to.Line 389 in
se.py
was raising aSerdeError: isinstance() argument 2 cannot be a parametrized generic
.For more on the DOOR API see here, with
is_bearable
specifically documented here As it mentions there, this is designed to replaceisinstance
by being a strict superset: