Exceptions app should refer to app/views/#{config.view_path}

yuki24 · Sep 5, 2014 · a33220b · a33220b
1 parent c18ef37
commit a33220b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/lib/rambulance/exceptions_app.rb b/lib/rambulance/exceptions_app.rb
@@ -50,11 +50,15 @@ def exception
     end
 
     def error_path(status_in_words = status_in_words())
-      "#{Rambulance.view_path}/#{status_in_words}"
+      "#{controller_path}/#{status_in_words}"
     end
 
     def layout_name
       Rambulance.layout_name
     end
+
+    def controller_path
+      Rambulance.view_path
+    end
   end
 end
diff --git a/spec/fake_app/lib/exceptions_app.rb b/spec/fake_app/lib/exceptions_app.rb
@@ -1,4 +1,6 @@
 class ExceptionsApp < Rambulance::ExceptionsApp
+  def not_found; end
+
   def internal_server_error
     render inline: <<-BODY
       <html>

diff --git a/spec/requests/error_page_spec.rb b/spec/requests/error_page_spec.rb
@@ -55,6 +55,14 @@
   context "With a custom exception app", if: ENV["CUSTOM_EXCEPTIONS_APP"] do
     it_behaves_like "an action that renders 500 page if the template is missing"
 
+    scenario 'Not found due to ActinoController::RoutingError' do
+      visit '/doesnt_exist'
+
+      page.status_code.should == 404
+      page.body.should have_content "Error page"
+      page.body.should have_content "Page not found."
+    end
+
     scenario 'Internal server error due to RuntimeError' do
       visit '/users/1'