Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#21157][DocDb]: Fix load_balancer_max_over_replicated_tablets description to reflect per-table status #24406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −7
Open

[#21157][DocDb]: Fix load_balancer_max_over_replicated_tablets description to reflect per-table status #24406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/preview/reference/configuration/yb-master.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ Default: `2`

##### --load_balancer_max_over_replicated_tablets

Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor.
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.
Copy link
Contributor

@ddhodge ddhodge Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.
Specifies the maximum number of running tablet replicas per table that are allowed beyond the configured replication factor. For example, if RF=3 and this flag is set to 3, you can have maximum 6 tablet replicas per table.


Default: `1`

Expand Down
2 changes: 1 addition & 1 deletion docs/content/stable/reference/configuration/yb-master.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ Default: `2`

##### --load_balancer_max_over_replicated_tablets

Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor.
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.

Default: `1`

Expand Down
2 changes: 1 addition & 1 deletion docs/content/v2.14/reference/configuration/yb-master.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ Default: `2`

##### --load_balancer_max_over_replicated_tablets

Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor.
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.

Default: `1`

Expand Down
2 changes: 1 addition & 1 deletion docs/content/v2.18/reference/configuration/yb-master.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ Default: `2`

##### --load_balancer_max_over_replicated_tablets

Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor.
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.

Default: `1`

Expand Down
2 changes: 1 addition & 1 deletion docs/content/v2.20/reference/configuration/yb-master.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ Default: `2`

##### --load_balancer_max_over_replicated_tablets

Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor.
Specifies the maximum number of running tablet replicas that are allowed to be over the configured replication factor per table.

Default: `1`

Expand Down
2 changes: 1 addition & 1 deletion src/yb/master/cluster_balance.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ DEFINE_RUNTIME_int32(load_balancer_max_concurrent_tablet_remote_bootstraps_per_t

DEFINE_RUNTIME_int32(load_balancer_max_over_replicated_tablets, 1,
"Maximum number of running tablet replicas that are allowed to be over the configured "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Maximum number of running tablet replicas that are allowed to be over the configured "
"Maximum number of running tablet replicas per table allowed in addition to the configured "

"replication factor.");
"replication factor per table.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"replication factor per table.");
"replication factor.");


DEFINE_RUNTIME_int32(load_balancer_max_concurrent_adds, 1,
"Maximum number of tablet peer replicas to add in any one run of the load balancer.");
Expand Down
2 changes: 1 addition & 1 deletion src/yb/master/cluster_balance_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ struct Options {
// time.
bool kAllowLimitOverReplicatedTablets = true;

// Max number of running tablet replicas that are over the configured limit.
// Max number of running tablet replicas that are over the configured limit per table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Max number of running tablet replicas that are over the configured limit per table.
// Max number of running tablet replicas per table allowed over the configured RF.

int kMaxOverReplicatedTablets = FLAGS_load_balancer_max_over_replicated_tablets;

// Max number of over-replicated tablet peer removals to do in any one run of the load balancer.
Expand Down