[#21963] YSQL: Add build definition for AWS clockbound FFI. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pao214
force-pushed
the
clockbound
branch
2 times, most recently
from
1c084e3
to
0392100
Compare
svarnau
reviewed
Sep 16, 2024
| @@ -175,3 +175,6 @@ def copy_include_files( | |||
| rel_src_include_path: str, | |||
| dest_include_path: str) -> None: | |||
| raise NotImplementedError() | |||
|
|
|||
| def prepare_for_build_tool_invocation(self, dep: 'Dependency') -> bool: | |||
There was a problem hiding this comment.
This is an already implemented function and it does the following things
- There is a skip_build_invocations command line option. And if this is set, then we should return immediately without building.
- It also checks that we are in the correct directory for building the library.
I simply added an interface here since no other library uses the rust compiler. I need to invoke the rust compiler myself because there is no API to do so. But I need to call this function similar to what C++ builds do.
svarnau
approved these changes
Sep 16, 2024
karthik-ramanathan-3006
approved these changes
Sep 17, 2024
The rust is pinned at version 1.78.0 in the build machines. We are not installing rust here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/aws/clock-bound lets us retrieve clock accuracies. This is accurate as long as the reference clock is accurate. This information helps us improve transaction performance.
Compiling clock-bound-ffi using rust generates a C library for use in YugabyteDB. This source code is licensed Apache 2.0.
As a part of this change, build clock-bound-ffi using rust. We package only the header file and the static library (not the shared library. Using static library consistently across all the build types reduces surprises).
clock-bound-ffi is a C library and not built with sanitizer support.
The option
--toolchain=llvm17has no bearing in how clock-bound-ffi is built.Also, replace ubuntu 23.04 with ubuntu 24.04 since (1) 24.04 is the newer and stable version and (2) yugabyte's 23.04 docker image does not have rust installed.