Skip to content

Commit

Permalink
[skip ci] Make build-type option actually work (#279)
Browse files Browse the repository at this point in the history
Currently, the `build-type` option does not work at all and it's
impossible to set it to anything.

Removing `type=str` makes it actually work.

Also, adds `str.lower` normalizer, so it's possible to use it with
yugabyte-db main builder, which uses `uninstrumented` (lowercase) as an
option.
  • Loading branch information
karelbilek authored Sep 21, 2024
1 parent 12f6cb8 commit 2fab888
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions python/yugabyte_db_thirdparty/cmd_line_args.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ def parse_cmd_line_args() -> argparse.Namespace:
parser = argparse.ArgumentParser(prog=sys.argv[0])
parser.add_argument('--build-type',
default=None,
type=str,
action=enum_action(BuildType),
action=enum_action(BuildType, str.lower),
help='Build only the third-party dependencies of the given type')
parser.add_argument('--skip-sanitizers',
action='store_true',
Expand Down

0 comments on commit 2fab888

Please sign in to comment.