Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOUDGA-24216] Simplify GCP FF #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CLOUDGA-24216] Simplify GCP FF #122

wants to merge 1 commit into from

Conversation

Siddarth-Baldwa
Copy link
Contributor

@Siddarth-Baldwa Siddarth-Baldwa commented Oct 28, 2024 •
edited
Loading

Changes

  1. Removed old GCP feature flagging due to complexity and poor error handling.
  2. Added a simpler, more reliable feature flag system.

Improvements

  1. Better Error Handling: Ensures smooth transitions when toggling the feature.
  2. Easier Future Integration: Simplifies code for easier expansion.

Output when creating a GCP integration when FF is disabled:
image

@Siddarth-Baldwa Siddarth-Baldwa marked this pull request as ready for review October 28, 2024 10:48
@Siddarth-Baldwa Siddarth-Baldwa requested a review from a team as a code owner October 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Siddarth-Baldwa