Jepsen 0.3.01 upgrade #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenspider
approved these changes
Dec 8, 2022
yugabyte/src/yugabyte/workaround.clj
Outdated
| (reduce (fn [m p] (assoc m p (count m))) | ||
| {}))) | ||
|
|
||
| (defn html |
There was a problem hiding this comment.
It seems that the current implementation of timeline/html is not very different to this, why can't we use it?
There was a problem hiding this comment.
Trying to understand what's needs to be changed here jepsen-io#564
These are the only tests (single-multi-key-acid) where checker is failed
| (if (= type :wrong-total) | ||
| {:lowest (util/min-by :total errs) | ||
| :highest (util/max-by :total errs)} | ||
| {}))])) |
There was a problem hiding this comment.
Looks like only whitespaces were changed here?
| [clojure.core.reducers :as r] | ||
| [jepsen | ||
| [history :as h] |
There was a problem hiding this comment.
Interesting, I don't see history.clj in jepsen - but I see it used all over Jepsen
There was a problem hiding this comment.
It's separated package now https://github.com/jepsen-io/history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.