Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latency calculation changes featurebench #83

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shaharuk-yb
Copy link

@shaharuk-yb shaharuk-yb commented May 16, 2023

  • zero rows as transaction status added
  • latencies of only success and zero_rows transaction will get added
  • added additional details like each transaction count in the .detailed.json. Sample output:
{
 "metadata": {
  "Rejected Transactions (Server Retry)": 0,
  "yaml_version": "v1.0",
  "Rejected Transactions (Retry Different)": 0,
  "Zero Rows Returned": 376,
  "Completed Transactions": 169,
  "Aborted Transactions": 0,
  "Unknown Status Transactions": 0,
  "Unexpected SQL Errors": 0
 },
 "Summary": {
  "scalefactor": null,
  "Current Timestamp (milliseconds)": 1684902971031,
  "Benchmark Type": "featurebench",
  "isolation": "TRANSACTION_REPEATABLE_READ",
  "DBMS Version": "PostgreSQL 11.2-YB-2.15.2.0-b0 on x86_64-pc-linux-gnu, compiled by clang version 13.0.1 (https://github.com/yugabyte/llvm-project.git 191e3a05a55c8671bcc88d7387c04c55a4310500), 64-bit",
  "Goodput (requests/second)": 33.79455554164729,
  "terminals": "1",
  "DBMS Type": "YUGABYTE",
  "Latency Distribution": {
   "95th Percentile Latency (microseconds)": 13178,
   "Maximum Latency (microseconds)": 20354,
   "Median Latency (microseconds)": 9943,
   "Minimum Latency (microseconds)": 6975,
   "25th Percentile Latency (microseconds)": 8732,
   "90th Percentile Latency (microseconds)": 12161,
   "99th Percentile Latency (microseconds)": 15489,
   "75th Percentile Latency (microseconds)": 11148,
   "Average Latency (microseconds)": 10086
  },
  "Throughput (requests/second)": 108.98244242720574
 },
 "queries": [{
  "explain": {
   "ResultSet": "Index Scan using update_test_table1_pkey on public.update_test_table1  (cost=0.00..4.11 rows=1 width=255) (actual time=2.700..2.707 rows=1 loops=1)\n  Output: id, col_int_1, col_int_2, col_int_3, col_int_4, col_int_5, col_int_6, col_int_7, col_int_8, col_int_9, col_int_10, col_varchar_1, col_varchar_2, col_varchar_3, col_date, col_boolean\n  Index Cond: (update_test_table1.id = 949)\nPlanning Time: 0.115 ms\nExecution Time: 2.764 ms\nPeak Memory Usage: 8 kB\n",
   "SQL": "explain (analyze,verbose,costs,buffers) select * from update_test_table1 where id = 949",
   "ClientSideExplainTime(ms)": 12
  },
  "prepared_statements": {},
  "query": "select * from update_test_table1 where id = ?",
  "pg_stat_statements": {}
 }]
}

Copy link

@hbhanawat hbhanawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify with feature bench regression runs before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants