Skip to content

Commit

Permalink
Cleanup unused things
Browse files Browse the repository at this point in the history
  • Loading branch information
zcbenz committed Apr 3, 2024
1 parent a192233 commit fdfd336
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# TypeScript compiled files
/dist/
/types/**/*.d.ts

# Everything else should keep same with .npmignore
*.swp
Expand Down
1 change: 0 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Unused source files
/src/
/types/
.github
tsconfig.json

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cross-platform desktop apps with system webview and native GUI widgets.

## Docs

* [Sign mac app](https://github.com/yue/boilerplate-js/blob/main/docs/sign-mac-app.md)
* [Sign mac app](https://github.com/yue/boilerplate-nodejs/blob/main/docs/sign-mac-app.md)
* [Yue documents (external link)](http://libyue.com/docs/latest/js/)

## License
Expand Down
12 changes: 8 additions & 4 deletions docs/sign-mac-app.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@ and you need to set following secrects in repo/orgnaization to make it work.

## `BUILD_CERTIFICATE_BASE64`/`P12_PASSWORD`/`KEYCHAIN_PASSWORD`

https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development
Check [Installing an Apple certificate on macOS runners for Xcode development](https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development)
on how to generate the required secrects for Apple certificate.

## `APPLE_TEAM_ID`

https://developer.apple.com/help/account/manage-your-team/locate-your-team-id/
The [Team ID](https://developer.apple.com/help/account/manage-your-team/locate-your-team-id/)
of your Apple Developer account is used for signing and notarizing the app
bundle.

## `APPLE_ID`/`APPLE_PASSWORD`

https://github.com/lando/notarize-action
https://support.apple.com/en-us/102654
This repo uses the [Notarize Action](https://github.com/lando/notarize-action)
to notarize the app bundle, which requires your Apple ID and an [app-specific
password](https://support.apple.com/en-us/102654).
2 changes: 0 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"compilerOptions": {
"declaration": true,
"declarationDir": "types",
"baseUrl": "src",
"outDir": "dist",
"allowJs": true,
Expand Down

0 comments on commit fdfd336

Please sign in to comment.