Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xfileshare] Add uqload.co support #32452

Closed
wants to merge 1 commit into from
Closed

[xfileshare] Add uqload.co support #32452

wants to merge 1 commit into from

Conversation

Theo2M
Copy link

@Theo2M Theo2M commented Jul 18, 2023

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

uqload.com now redirects to uqload.co

@dirkf
Copy link
Contributor

dirkf commented Jul 18, 2023

Thanks.

[x] Covered the code with tests (note that PRs without tests will be REJECTED)

Not so much, really. At a minimum there should be an only_matching test; ideally an actual test video that can be downloaded (its first 10kB, anyway) and whose metadata does not indicate "pirated" material.

If there are tests I can enable the CI test ...

@Theo2M
Copy link
Author

Theo2M commented Jul 20, 2023

OK, Thanks a lot for the clearly explication. I add the "only_matching" test.

@dirkf
Copy link
Contributor

dirkf commented Feb 21, 2024

Superseded by #32725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants