Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Machnumber field spelling in amrex frontend for Castro #4994

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix Machnumber field spelling in amrex frontend for Castro #4994

merged 1 commit into from
Sep 18, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 15, 2024

also add abar and Ye as defined fields so they print well

PR Summary

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@zingale
fix Machnumber field spelling in amrex frontend for Castro
510c213 
also add abar and Ye as defined fields so they print well
@zingale zingale added the code frontends Things related to specific frontends label Sep 15, 2024
@zingale zingale added the enhancement Making something better label Sep 16, 2024
@chrishavlin chrishavlin added this to the 4.4.0 milestone Sep 18, 2024
yut23
yut23 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@yut23 yut23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neutrinoceros neutrinoceros merged commit 43af362 into yt-project:main Sep 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin approved these changes

@yut23 yut23 yut23 approved these changes

Assignees

@yut23 yut23

Labels
code frontends Things related to specific frontends enhancement Making something better
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zingale @yut23 @chrishavlin @neutrinoceros