BLD: fix compatibility with Cython 3.1 #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
build
neutrinoceros
force-pushed
the
bld/remove_Cython_DEF
branch
2 times, most recently
from
d08d348
to
82994dc
Compare
neutrinoceros
changed the title
Cython (drop deprecated DEF statements)
neutrinoceros
force-pushed
the
bld/remove_Cython_DEF
branch
3 times, most recently
from
f9ddcaf
to
01b10d7
Compare
chrishavlin
previously approved these changes
Jul 22, 2024
neutrinoceros
commented
Jul 26, 2024
|
|
||
| from yt.utilities.lib.fp_utils cimport * | ||
|
|
||
| from .oct_container cimport Oct, OctreeContainer | ||
|
|
||
| cdef extern from "numpy/npy_math.h": | ||
| double NPY_PI |
There was a problem hiding this comment.
To see why this change was needed, see https://cython.readthedocs.io/en/latest/src/changes.html#other-changes
The previously shipped NumPy C-API declarations (cimport numpy) were removed. NumPy has been providing version specific declarations for several versions now. (Github issue #5842)
neutrinoceros
changed the title
Cython (drop deprecated DEF statements)
|
This looks good to me, but since it's been a while and the sph projections touched a lot of cython, I think it'd be nice to merge with main here to double check that we haven't introduced any additional compatibility issues. What do you think? |
neutrinoceros
force-pushed
the
bld/remove_Cython_DEF
branch
from
e643586
to
8a4003f
Compare
|
rebased on the tip of main ! |
chrishavlin
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #4044
Following Cython's migration guide