[WIP] Experimentally turn off precounting AMR datasets #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly, the way the grid selections are set up doesn't lend itself to the resizing I'm attempting. I do think this is still quite a nice area for improvement, though, so I will try to lift the references up a level to perform this surgery more carefully. |
|
Resize behaves a bit strangely if the original shape is empty and you resize it to a single value. So this shows up when we have chunks consisting of a single grid with a single value selected, which happens inside |
|
@yt-fido test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests done by me, @cindytsai and @chrishavlin suggest that parallelism in particular is greatly limited by the amount of duplicated indexing that goes on across MPI tasks.
This is an experiment to see how we fare with turning off pre-counting, which should greatly reduce the amount of time spent in the counting routines, and potentially speed things up overall.