Updates to units section #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quantity, fixing other things
|
@matthewturk I forgot to add a short bit on physical constants. |
|
Thanks John for taking my first comments into account ! I'll try to do a more thorough review by the end of the week. |
|
|
||
| ### Creating YTArray and YTQuantity instances {#sec:creating-ytarray-and-ytquantity-instances} | ||
| Some physical constants are represented by Greek letters or other characters--these can be imported either using ASCII characters or | ||
| their non-ASCII representations: |
There was a problem hiding this comment.
It might be good to also demonstrate this part, as the non-ASCII names may not be obvious to the reader (they aren't to me)
Co-authored-by: Clément Robert <[email protected]>
neutrinoceros
approved these changes
Sep 8, 2023
|
@jzuhone I think this is good to go. I'm going to issue a followup PR that converts it back to semantic line-breaks. |
matthewturk
added a commit
that referenced
this pull request
Sep 12, 2023
[ci skip] This build is based on 6a4368f. This commit was created by the following CI build and job: https://github.com/yt-project/yt-4.0-paper/commit/6a4368fb4fb9dc7232cceac20c12ff0021afd4d5/checks https://github.com/yt-project/yt-4.0-paper/actions/runs/6161592656
matthewturk
added a commit
that referenced
this pull request
Sep 12, 2023
[ci skip] This build is based on 6a4368f. This commit was created by the following CI build and job: https://github.com/yt-project/yt-4.0-paper/commit/6a4368fb4fb9dc7232cceac20c12ff0021afd4d5/checks https://github.com/yt-project/yt-4.0-paper/actions/runs/6161592656
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite and update of the symbolic units section.
Closes #80