Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: switch to Cython 3.0, forbid deprecated Numpy C API in generated code #51

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

neutrinoceros
Copy link
Member

No description provided.

@matthewturk
Copy link
Member

my guess is that we'll see pretty enormous performance regressions here if we aren't careful

@neutrinoceros
Copy link
Member Author

Yes, that's what I'm worried about too. Is there a way to test for it that doesn't involve running yt's test suite ?
Maybe we could just systematically change nogil into noexcept nogil ?

@matthewturk
Copy link
Member

I think that's a good idea. It might be sufficient just to do some SPH queries with this to demonstrate the slowndown; I bet they will show up in larger runs, but not smaller ones.

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jul 28, 2023

Actually nogil only shows up on one line

cdef extern from "<algorithm>" namespace "std" nogil:
Iter unique[Iter](Iter first, Iter last)

I confess I do not understand this definition. Is it critical ?

@neutrinoceros
Copy link
Member Author

ping @matthewturk

@neutrinoceros
Copy link
Member Author

I'm thinking we could do a release candidate to enabling testing on yt without compromising performance on production for anyone.

@matthewturk matthewturk merged commit 181564d into yt-project:main Aug 15, 2023
14 checks passed
@neutrinoceros neutrinoceros deleted the cython3 branch August 15, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants