[REGRESSION] remove list virtualization #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes scrolling issues on ios in the old virtualization implementation, the intersection observer was not getting trigerred for the threshold of 1.0 reducing this to 0.83 caused scrolling issues on firefox instead during list re-ordering.
reduce per element consumption from ~200KiB to ~120KiB
Merged
saikatdas0790
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #65
(Weird stuttering on ios is still present, possible fix is in investigation)
To mitigate this effective memory leak, we're hiding video elements which are way up in the view
per rough calculations, each element is consuming ~120 KiB on firefox linux
to saturate the memory usage to ~500 MiB the user would have to scroll roughly more than 4200 times