Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA logo config and host state #637

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PWA logo config and host state #637

wants to merge 1 commit into from
+233 −97

Conversation

harsh-mahajan-yral
Copy link
Contributor

@harsh-mahajan-yral harsh-mahajan-yral commented Jan 30, 2025 •
edited
Loading

resolves #638
resolves #639

  • added latest logo for PnD, ICP, HON
  • the app type is used for detecting host and assigning app state which can be used in any way
  • app.webmanifest contains all configs for PWAs, it will be loaded to config depending on app state

@harsh-mahajan-yral harsh-mahajan-yral self-assigned this Jan 30, 2025
@harsh-mahajan-yral harsh-mahajan-yral marked this pull request as ready for review January 30, 2025 20:40
@siyara-m-yral
Copy link

  • Blocked because of deploy link being limited

@harsh-mahajan-yral harsh-mahajan-yral changed the title PWA logo config PWA logo config and host state Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupansh-sekar-yral rupansh-sekar-yral Awaiting requested review from rupansh-sekar-yral

At least 1 approving review is required to merge this pull request.

Assignees

@rupansh-sekar-yral rupansh-sekar-yral

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detecting host when app loads PWA icons change
3 participants
@harsh-mahajan-yral @siyara-m-yral @rupansh-sekar-yral