feat(doc): 新增codesandbox支持 #12332
Open
feat(doc): 新增codesandbox支持 #12332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
chenjiahan
reviewed
Oct 2, 2023
packages/vant-cli/package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "@types/less": "^3.0.3", | |||
| "@types/lodash": "^4.14.191", | |||
| "@types/markdown-it": "^13.0.0", | |||
| "codesandbox": "^2.2.3", | |||
There was a problem hiding this comment.
这个依赖让 lock 文件增加了 1600 行，而 Vant 仓库是希望严格控制依赖梳理的。
能否看一下是否有体积更小的依赖。。
|
好，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月2日 21:29
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
@chenjiahan commented on this pull request.
In packages/vant-cli/package.json:
> @@ -42,6 +42,7 @@ ***@***.***/less": "^3.0.3", ***@***.***/lodash": "^4.14.191", ***@***.***/markdown-it": "^13.0.0", + "codesandbox": "^2.2.3",
这个依赖让 lock 文件增加了 1600 行，而 Vant 仓库是希望严格控制依赖梳理的。
能否看一下是否有体积更小的依赖。。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
这个 PR 可以 review 了嘛？ |
|
可以哈，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月13日 20:21
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
这个 PR 可以 review 了嘛？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
看了下样式还有点粗糙，另外似乎没有把 template / scripts 放到同一个 codesandbox 里面，这两块能优化下吗 |
|
样式的话需要提供一个参考，这个样式都是我随便写的，主要不知道按钮放哪还有规范
…------------------ 原始邮件 ------------------
发件人: "youzan/vant" ***@***.***>;
发送时间: 2023年10月17日(星期二) 上午9:16
***@***.***>;
***@***.******@***.***>;
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
看了下样式还有点粗糙，另外似乎没有把 template / scripts 放到同一个 codesandbox 里面，这两块能优化下吗
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
ok，那样式可以等合并完我再优化下，另外「template / scripts 放到同一个 codesandbox 里面」的问题准备如何解决呢 |
|
这个我看一下哈，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月22日 08:18
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
ok，那样式可以等合并完我再优化下，另外「template / scripts 放到同一个 codesandbox 里面」的问题准备如何解决呢
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@chenjiahan |
|
可能是因为大部分组件的 template 和 scripts 是分开写在两个 code blocks 里的，而不是上图的合并成一个 code block |
chenjiahan
reviewed
Oct 23, 2023
| title: meta.title, | ||
| dependencies: { | ||
| vue: 'latest', | ||
| vant: 'latest', |
There was a problem hiding this comment.
Vant CLI 是一个通用的组件库工具，所以代码里不能和 vant 包产生耦合，这种可以通过参数控制
chenjiahan
reviewed
Oct 23, 2023
| vant: 'latest', | ||
| }, | ||
| devDependencies: { | ||
| '@vue/cli-plugin-babel': '~4.5.0', |
|
是不是要加一个组件白名单呢，目前只有 button 和 cell 适配了，其他组件先不展示对应的 codesandbox 图标 |
|
可以的，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月24日 07:32
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
@chenjiahan commented on this pull request.
In packages/vant-cli/site/desktop/components/getCodeSandboxParams.js:
> +app.mount("#app"); +`; + +export function getCodeSandboxParams(code, meta) { + return getParameters({ + files: { + 'package.json': { + content: JSON.stringify( + { + title: meta.title, + dependencies: { + vue: 'latest', + vant: 'latest', + }, + devDependencies: { + ***@***.***/cli-plugin-babel': '~4.5.0',
可以换成 Vite 吗
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
我看了其他组件库的，都是放在一个文件里面的，目前基本都是一个vue文件放template和script的代码，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月24日 07:30
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
可能是因为大部分组件的 template 和 scripts 是分开写在两个 code blocks 里的，而不是上图的合并成一个 code block
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
可以配置一个哈，文档可以慢慢完善，
发自我的iPhone
…------------------ 原始邮件 ------------------
发件人: neverland ***@***.***>
发送时间: 2023年10月24日 07:33
收件人: youzan/vant ***@***.***>
抄送: luopei ***@***.***>, Author ***@***.***>
主题: Re: [youzan/vant] feat(doc): 新增codesandbox支持 (PR #12332)
是不是要加一个组件白名单呢，目前只有 button 和 cell 适配了，其他组件先不展示对应的 codesandbox 图标
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
文档新增codesandbox支持，目前做了一个demo，修改了button和field的文档示例 。