blink: Add H5vccMetrics IDL, Blink implementation and Mojom #5047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeltine
reviewed
Mar 10, 2025
| @@ -1211,6 +1211,8 @@ if (is_cobalt) { | |||
| [ | |||
| "//third_party/blink/renderer/modules/cobalt/crash_log/crash_log.idl", | |||
| "//third_party/blink/renderer/modules/cobalt/encryptedmedia/media_keys_extensions.idl", | |||
| "//third_party/blink/renderer/modules/cobalt/h5vcc_metrics/metrics_event.idl", | |||
| "//third_party/blink/renderer/modules/cobalt/h5vcc_metrics/h_5_vcc_metrics.idl", | |||
There was a problem hiding this comment.
can we keep the original file naming like: h5vcc_metrics.h|idl|cc?
joeltine
reviewed
Mar 10, 2025
| }; | ||
|
|
||
| interface H5vccMetrics { | ||
| AddListener(pending_remote<MetricsListener> listener) => (); |
There was a problem hiding this comment.
This could be my ignorance, but how does this map to the current onMetricEvent in H5vccMetrics?
There was a problem hiding this comment.
Ah, I forgot to tie this in from H5vccMetrics::setOnmetrics() (had it but must have removed it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds:
onmetricsEvent (with a "tbd" field).Bug: b/372559349