Use json recipes for release packaging #5044
Open
+260
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
approved these changes
Mar 8, 2025
| @@ -0,0 +1,73 @@ | |||
| #!/usr/bin/env python3 | |||
| """Packages Cobalt with a given layout.""" | |||
|
|
|||
There was a problem hiding this comment.
Please put a comment here at the top as to where the JSON format comes from. A link to the origin Proto schema from Chromium, and a mention that we only implement a subset.
Also - a small test just to show that files, dirs, rename_files and rename_dirs keys are respected.
Other than that LGTM
Use Chromium's json recipe format for creating release packages on Kokoro. b/393447640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Chromium's json recipe format for creating release packages on Kokoro.
b/393447640