Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libxml] Hashing of empty dict strings isn't deterministic #5011

Open
wants to merge 2 commits into
base: 25.lts.1+
Choose a base branch
from
Open

[libxml] Hashing of empty dict strings isn't deterministic #5011

wants to merge 2 commits into from

Conversation

dahlstrom-g
Copy link
Contributor

Issue: 399225618

nwellnhof and others added 2 commits January 28, 2025 14:00
@nwellnhof @dahlstrom-g
[CVE-2023-29469] Hashing of empty dict strings isn't deterministic
2c7a482 
When hashing empty strings which aren't null-terminated,
xmlDictComputeFastKey could produce inconsistent results. This could
lead to various logic or memory errors, including double frees.

For consistency the seed is also taken into account, but this shouldn't
have an impact on security.

Found by OSS-Fuzz.

Fixes youtube#510.

(cherry picked from commit 547edbf1cbdccd46b2e8ff322a456eaa5931c5df)
@dahlstrom-g
Designate CVE-2023-29469 as mitigated
441f1e3 
Issue: 399225618
Reviewed-on: youtube#5011
@dahlstrom-g dahlstrom-g requested a review from kaidokert March 4, 2025 15:00
@kaidokert kaidokert changed the title Hashing of empty dict strings isn't deterministic [libxml] Hashing of empty dict strings isn't deterministic Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidokert kaidokert kaidokert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahlstrom-g @kaidokert @nwellnhof