Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxml] Fix integer overflows in xmlBuf and xmlBuffer #5009

Open
wants to merge 2 commits into
base: 25.lts.1+
Choose a base branch
from

Conversation

dahlstrom-g
Copy link
Contributor

Issue: 399225618

nwellnhof and others added 2 commits January 28, 2025 14:00
In several places, the code handling string buffers didn't check for
integer overflow or used wrong types for buffer sizes. This could
result in out-of-bounds writes or other memory errors when working on
large, multi-gigabyte buffers.

Thanks to Felix Wilhelm for the report.

(cherry picked from commit 2554a2408e09f13652049e5ffb0d26196b02ebab)
Issue: 399225618
Reviewed-on: youtube#5009
@dahlstrom-g dahlstrom-g requested a review from kaidokert March 4, 2025 15:00
@kaidokert kaidokert changed the title Fix integer overflows in xmlBuf and xmlBuffer [libxml] Fix integer overflows in xmlBuf and xmlBuffer Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants