Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cobalt_apk to build dev.cobalt.coat #4304

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

johnxwork
Copy link
Contributor

@johnxwork johnxwork commented Oct 23, 2024

This new target generate CobaltShell.apk that has dev.cobalt.coat as its package name, and include most of Cobalt's java code.

App starts from CobaltActivity now. CobaltActivity inherits from ContentShellActivity now instead of GameActivity.

Remember to put treat_warnings_as_errors = false in gn args since Chromium treats java warnings as errors and we have many.

There are many TODOs left in this CL and this is only to be served as a prototype to unblock SbPlayer and JS injection.

b/374191454

@johnxwork johnxwork requested a review from a team as a code owner October 23, 2024 01:30
@johnxwork
Copy link
Contributor Author

This is very ugly at the moment. But I'm uploading the draft right now to see if it can help unblock Colin and Bo-Rong.

Copy link
Contributor

@zhongqiliang zhongqiliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it locally, submit it once you are good with it.

Copy link
Contributor

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a few comments on the gn.

The modifications to the files are of course hacks -- I wonder
whether we could have a way to track those later on (e.g. just a
//TODO(cobalt) next to the would be enough).

cobalt/BUILD.gn Outdated Show resolved Hide resolved
cobalt/android/BUILD.gn Show resolved Hide resolved
cobalt/android/BUILD.gn Outdated Show resolved Hide resolved
@johnxwork johnxwork force-pushed the chroat branch 2 times, most recently from 6a4910d to 254b87d Compare October 25, 2024 20:06
@jellefoks
Copy link
Member

jellefoks commented Oct 25, 2024

Can we use cobalt_apk and generate Cobalt.apk instead of cobalt_shell_apk/CobaltShell.apk? The target to build is cobalt, not a shell for cobalt.

It seems that the changes already do that, but the PR description doesn't reflect it.

@johnxwork johnxwork force-pushed the chroat branch 2 times, most recently from e974802 to 224f134 Compare October 28, 2024 20:43
@johnxwork johnxwork changed the title cobalt_shell_apk to build dev.cobalt.coat cobalt_apk to build dev.cobalt.coat Oct 28, 2024
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - it could still be cleaned up quite a bit, but i'm okay with doing this as follow-up

This new target generate Cobalt.apk that has dev.cobalt.coat as its package name, and include most of Cobalt's java code.

App starts from CobaltActivity now. CobaltActivity inherits from ContentShellActivity now instead of GameActivity.

Remember to put treat_warnings_as_errors = false in gn args since Chromium treats java warnings as errors and we have many.

There are many TODOs left in this CL and this is only to be served as a prototype to unblock SbPlayer and JS injection.

b/374191454
@johnxwork johnxwork merged commit c9084fe into youtube:main Oct 29, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants